Skip to content

add MultiIR Siren MIR-SR100#2873

Open
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_siren_MIR-SR100
Open

add MultiIR Siren MIR-SR100#2873
thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
thinkaName:multiir_siren_MIR-SR100

Conversation

@thinkaName
Copy link
Copy Markdown
Contributor

@thinkaName thinkaName commented Apr 3, 2026 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/WnlLkNg3k02K

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026 •
edited
Loading

Test Results

   72 files    507 suites   0s ⏱️
2 787 tests 2 787 ✅ 0 💤 0 ❌
4 676 runs  4 676 ✅ 0 💤 0 ❌

Results for commit 45687a6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026 •
edited
Loading

File Coverage
All files 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/lazy_load_subdriver.lua 57% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/frient/init.lua 97% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-siren/src/MultiIR/init.lua 97% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 45687a6

@thinkaName thinkaName force-pushed the multiir_siren_MIR-SR100 branch from 310380b to 45687a6 Compare April 29, 2026 02:54
cjswedes
cjswedes reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a couple style things, and one issue with handling nil preferences (which shouldnt happen, but the logic could pass a boolean rather than the default if it was nil).

Comment thread drivers/SmartThings/zigbee-siren/src/MultiIR/init.lua
Comment on lines +74 to +77
local sirenVolume_msg = tonumber(device.preferences.sirenVolume)
local warning_duration = tonumber(device.preferences.warningDuration)

send_siren_command(device, WarningMode , sirenVolume_msg == nil or IaswdLevel.VERY_HIGH_LEVEL ,warning_duration == nil or DEFAULT_MAX_WARNING_DURATION, Strobe, strobe_level)
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local sirenVolume_msg = tonumber(device.preferences.sirenVolume)
local warning_duration = tonumber(device.preferences.warningDuration)
send_siren_command(device, WarningMode , sirenVolume_msg == nil or IaswdLevel.VERY_HIGH_LEVEL ,warning_duration == nil or DEFAULT_MAX_WARNING_DURATION, Strobe, strobe_level)
local sirenVolume_msg = tonumber(device.preferences.sirenVolume) or IaswdLevel.VERY_HIGH_LEVEL
local warning_duration = tonumber(device.preferences.warningDuration) or DEFAULT_MAX_WARNING_DURATION
warning_duration = math.min(DEFAULT_MAX_WARNING_DURATION, warning_duration)
send_siren_command(device, WarningMode , sirenVolume_msg , warning_duration, Strobe, strobe_level)

Comment thread drivers/SmartThings/zigbee-siren/src/test/test_multiir_zigbee_siren_tamper.lua
IASZone.attributes.ZoneStatus:read(mock_device)
}
},
{
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: indentation incorrect

Comment thread drivers/SmartThings/zigbee-siren/src/test/test_multiir_zigbee_siren_tamper.lua
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that validates a preference that is not the default for the warning duration and siren volume

Comment thread ...martThings/zigbee-siren/profiles/switch-alarm-tamper-warningduration-volume-no-fw-update.yml
- id: main
capabilities:
- id: switch
version: 1
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes left review comments

@aleclorimer aleclorimer Awaiting requested review from aleclorimer

@nand-nor nand-nor Awaiting requested review from nand-nor

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thinkaName @cjswedes