Matter Switch: Version gate the extra init event on added#2938
Open
hcarter-775 wants to merge 1 commit intomainfrom
Open
Matter Switch: Version gate the extra init event on added#2938hcarter-775 wants to merge 1 commit intomainfrom
hcarter-775 wants to merge 1 commit intomainfrom
Conversation
hcarter-775
requested review from
aleclorimer,
cjswedes,
ctowns and
nickolas-deboom
hcarter-775
force-pushed
the
version-gate-added-subscription
branch
from
4c49ecc to
ca47e49
Compare
|
Invitation URL: |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against f554da0 |
hcarter-775
force-pushed
the
version-gate-added-subscription
branch
from
ca47e49 to
f554da0
Compare
Test Results 72 files 506 suites 0s ⏱️ Results for commit f554da0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
As of Hub FW 58, the caching issues have been solved and so this extra event is not required any longer.
Summary of Completed Tests
This changeset is large primarily because I took this opportunity to restructure several test files that were checking the entire added -> init -> doConfigure cycle for every test, or that were testing pieces of code that were already tested elsewhere verbatim. I also just removed the added check in several places for simplicity, rather than re-versioning ~100 tests.
In particular, I really took the hammer to test_matter_switch.lua and test_light_illuminance_motion.lua, since there was significant overlap between these 2 and they were the first ones I looked at. I think a similar treatment is likely due for many of our Generic Switch tests, but I selectively reworked pieces as time permitted.