Fix reporting negated operands#600
Draft
MrAnno wants to merge 5 commits into
Draft
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: László Várady <laszlo.varady@anno.io>
Several combinators in the same argument list did not compile:
cr_assert(all(any(eq(int, 1, 1)), any(eq(int, 2, 2))));
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: László Várady <laszlo.varady@anno.io>
Reports cannot name the enclosing not(), and the bare inner expansion was an expression statement that triggered -Wunused-value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: László Várady <laszlo.varady@anno.io>
When a sub-assertion fails under not() or none(), its operands are recorded precisely because they matched, the runner could not tell the case apart from a genuinely broken user stringifier and wrongly blamed user code for a perfectly healthy assertion (Snaipe#594): cr_expect(none(eq(int, 1, 1), eq(int, 3, 3), eq(int, 3, 3))); [----] eq(int, 1, 1): [----] @@@ <no difference -- this is a user bug in the object stringifier> New output: [----] none(eq(int, 1, 1), eq(int, 3, 3), eq(int, 3, 3)): [----] eq(int, 1, 1): passed, but was expected to fail [----] actual: 1 [----] expected: 1 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: László Várady <laszlo.varady@anno.io>
Signed-off-by: László Várady <laszlo.varady@anno.io>
MrAnno
force-pushed
the
fix/594-negation-reporting
branch
from
July 19, 2026 13:39
37d90a6 to
852865e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #594