Skip to content

Conversation

@svij-sc
Copy link
Collaborator

@svij-sc svij-sc commented Jul 10, 2025

Scope of work done

Still some work left to be able to run the e2e examples.
Limiting the scope for this just to be able to install GLT as a post-install step. The scope of getting this to work w/ our quick start instructions e2e is much larger - thus want to get in first.

With this change you should be able to:

  1. Install keyring so pip can pull packages from google artifact registry
pip install keyrings.google-artifactregistry-auth
  1. Install gigl
pip install "gigl[torch25-cuda-121,transform]==0.0.3" \
  --index-url=https://us-central1-python.pkg.dev/external-snap-ci-github-gigl/gigl/simple/ \
  --extra-index-url=https://pypi.org/simple
  1. run the post install script to install GLT
gigl-post-install

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: YES

svij-sc and others added 2 commits July 9, 2025 19:20
svij-sc and others added 2 commits July 14, 2025 23:38
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
@svij-sc
Copy link
Collaborator Author

svij-sc commented Jul 15, 2025

/unit_test

@svij-sc
Copy link
Collaborator Author

svij-sc commented Jul 15, 2025

/integration_test

@svij-sc
Copy link
Collaborator Author

svij-sc commented Jul 15, 2025

/e2e_test

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025

GiGL Automation

@ 18:19:37UTC : 🔄 Unit Test started.

@ 19:00:13UTC : ✅ Workflow completed successfully.

@github-actions
Copy link
Contributor

GiGL Automation

@ 18:19:40UTC : 🔄 Integration Test started.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2025

GiGL Automation

@ 18:19:46UTC : 🔄 E2E Test started.

@ 19:52:05UTC : ✅ Workflow completed successfully.

@Snapchat Snapchat deleted a comment from github-actions bot Jul 15, 2025
Co-authored-by: Shubham Vij <[email protected]>
@github-actions
Copy link
Contributor

GiGL Automation

@ 20:42:29UTC : Starting to build base images for CUDA and CPU.
This may take a while, please be patient.
The images will be pushed to the GCP Artifact Registry.
Once done, the workflow will update the dep_vars.env file with the new image names.

Co-authored-by: Shubham Vij <[email protected]>
@github-actions
Copy link
Contributor

GiGL Automation

@ 21:02:46UTC : Starting to build base images for CUDA and CPU.
This may take a while, please be patient.
The images will be pushed to the GCP Artifact Registry.
Once done, the workflow will update the dep_vars.env file with the new image names.

Copy link
Collaborator

@nshah-sc nshah-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this solution -- I agree there might be another path but ultimately I think this is a pretty sufficient unblock to current issues. Compiling the wheels to simplify even further would be nice but I don't think the current solution is overly complex or error-prone so I don't see a too-strong need to carve out additional work to support that.

svij-sc and others added 2 commits July 15, 2025 15:49
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
@github-actions
Copy link
Contributor

GiGL Automation

@ 22:50:03UTC : Starting to build base images for CUDA and CPU.
This may take a while, please be patient.
The images will be pushed to the GCP Artifact Registry.
Once done, the workflow will update the dep_vars.env file with the new image names.

@github-actions
Copy link
Contributor

GiGL Automation

@ 21:09:35UTC : Starting to build base images for CUDA and CPU.
This may take a while, please be patient.
The images will be pushed to the GCP Artifact Registry.
Once done, the workflow will update the dep_vars.env file with the new image names.

@github-actions
Copy link
Contributor

GiGL Automation

@ 21:27:20UTC : Built and pushed new images:

  • CUDA base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-cuda-base:148f1c215806a7feb36663180c6e200548a94da4.25.1
  • CPU base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-cpu-base:148f1c215806a7feb36663180c6e200548a94da4.25.1
  • Dataflow base image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/public-gigl/gigl-dataflow-base:148f1c215806a7feb36663180c6e200548a94da4.25.1
  • Builder image: us-central1-docker.pkg.dev/external-snap-ci-github-gigl/gigl-base-images/gigl-builder:148f1c215806a7feb36663180c6e200548a94da4.25.1

Updated dep_vars.env with new image names.
Updated .github/cloud_builder/run_command_on_pr_cloud_build.yaml with new builder image.

Co-authored-by: Shubham Vij <[email protected]>
Copy link
Collaborator

@kmontemayor2-sc kmontemayor2-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would prefer if @yliu2-sc or @nshah-sc stamped too tho

Copy link
Contributor

@nshah171 nshah171 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work!

@svij-sc svij-sc marked this pull request as ready for review July 22, 2025 22:35
@svij-sc svij-sc added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 4f39b6f Jul 22, 2025
6 checks passed
@svij-sc svij-sc deleted the svij/install-glt-through-toml branch July 22, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants