-
Notifications
You must be signed in to change notification settings - Fork 12
Add ability to install GLT through a post-install-script #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
|
/unit_test |
|
/integration_test |
|
/e2e_test |
GiGL Automation@ 18:19:37UTC : 🔄 @ 19:00:13UTC : ✅ Workflow completed successfully. |
GiGL Automation@ 18:19:40UTC : 🔄 |
GiGL Automation@ 18:19:46UTC : 🔄 @ 19:52:05UTC : ✅ Workflow completed successfully. |
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
GiGL Automation@ 20:42:29UTC : Starting to build base images for CUDA and CPU. |
Co-authored-by: Shubham Vij <[email protected]>
GiGL Automation@ 21:02:46UTC : Starting to build base images for CUDA and CPU. |
nshah-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this solution -- I agree there might be another path but ultimately I think this is a pretty sufficient unblock to current issues. Compiling the wheels to simplify even further would be nice but I don't think the current solution is overly complex or error-prone so I don't see a too-strong need to carve out additional work to support that.
Co-authored-by: Shubham Vij <[email protected]>
Co-authored-by: Shubham Vij <[email protected]>
GiGL Automation@ 22:50:03UTC : Starting to build base images for CUDA and CPU. |
Co-authored-by: Shubham Vij <[email protected]>
GiGL Automation@ 21:09:35UTC : Starting to build base images for CUDA and CPU. |
GiGL Automation@ 21:27:20UTC : Built and pushed new images:
Updated |
Co-authored-by: Shubham Vij <[email protected]>
kmontemayor2-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nshah171
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work!
Scope of work done
Still some work left to be able to run the e2e examples.
Limiting the scope for this just to be able to install GLT as a post-install step. The scope of getting this to work w/ our quick start instructions e2e is much larger - thus want to get in first.
With this change you should be able to:
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: YES