Fixes #391#393
Open
codingkoaladev wants to merge 2 commits into
Open
Conversation
Refactor submenu template handling based on mobile menu identifier.
Update submenu template logic for mobile menus
|
@codingkoaladev the proposed change introduces Hyvä-specific logic into the menu block, which must be agnostic as it's also used for Luma based themes. Instead, can we please change this to be a small new try/catch block that logs such error and falls back to the default subtemplate? This would prevent invalid subtemplates from breaking the page, while ensuring that menus in a transitive state still carry such property for when they're done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.