Fix --update-hypervisor flag not triggering updates#399
Open
shbatm wants to merge 1 commit intoSolvik:masterfrom
Open
Fix --update-hypervisor flag not triggering updates#399shbatm wants to merge 1 commit intoSolvik:masterfrom
shbatm wants to merge 1 commit intoSolvik:masterfrom
Conversation
The --update-hypervisor flag was defined in config.py and checked in server.py, but was missing from the condition in cli.py that triggers netbox_create_or_update(). This meant running with --update-hypervisor alone would do nothing. Added config.update_hypervisor to the condition at cli.py line 48-56 so that the flag now properly triggers the hypervisor update logic in server.py. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
--update-hypervisorflag was defined in config.py and its logic was implemented in server.py:442-443, but it was missing from the condition in cli.py:48-56 that triggersnetbox_create_or_update().This meant running
netbox_agent --update-hypervisorwould do nothing because the update method was never called.Fixes: #400
Solution
Added
config.update_hypervisorto the condition in cli.py so that the flag now properly triggers the hypervisor update logic.Changes
or config.update_hypervisorto the condition at cli.py:48-56Testing
With this fix, running
netbox_agent --update-hypervisorwill now correctly callserver.netbox_create_or_update(config), which will trigger the hypervisor cluster and VM updates whenconfig.virtual.hypervisoris true.🤖 Generated with Claude Code