Skip to content

refactor(contributors): move order to pivot table#313

Open
czaja307 wants to merge 3 commits into
mainfrom
refactor/milestone-order
Open

refactor(contributors): move order to pivot table#313
czaja307 wants to merge 3 commits into
mainfrom
refactor/milestone-order

Conversation

@czaja307

Copy link
Copy Markdown
Member

No description provided.

@czaja307 czaja307 self-assigned this May 31, 2026
@czaja307 czaja307 requested a review from a team as a code owner May 31, 2026 15:52
@github-actions

Copy link
Copy Markdown
Contributor

Looks like you did not link an issue to this PR. If this PR completes a task, consider linking it.

@mini-bomba

Copy link
Copy Markdown
Member

there's a reason why we didn't add the order field to the pivot table
the reason being that the API would absolutely suck to use (changing the value would involve deleting and recreating the relationship)

i see two solutions:

  • either make the pivot table an actual table & model (breaking change)
  • or hack in a way to modify n:m relationship properties (which honestly shouldn't be that difficult, it would just be jank, as we'd be circumventing adonis' model system)

@Infor-Tech Infor-Tech linked an issue Jun 1, 2026 that may be closed by this pull request
@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Jun 2, 2026
@czaja307 czaja307 force-pushed the refactor/milestone-order branch from e7af866 to e03f5c2 Compare June 2, 2026 13:35
@czaja307 czaja307 force-pushed the refactor/milestone-order branch from e03f5c2 to d06beba Compare June 2, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: contributors order per milestone

2 participants