fix(ui): add stroke to player name#110
Open
Oskipol wants to merge 1 commit into
Open
Conversation
bnszky
requested changes
Jun 7, 2026
bnszky
left a comment
bnszky
left a comment
Member
There was a problem hiding this comment.
Wciąż trochę mało czytelny jest ten tekst. Proponuję dodać prostokąt z radiusem i stworzyć "dymek" nad graczem. Wtedy nie będzie problemu z tym, że tło jest ciemniejsze lub jaśniejsze i nick będzie dobrze widoczny.
Dodatkowo zauważyłem, że local jest zawsze false. Także popraw logikę przekazywania local do obiektu. Local powinien być true dla aktualnego gracza, pozostali gracze w roomie mają local = false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zwiększyłem rozmiar nicku gracza do 26 px i dodałem obrys na strokeThickness: 2. Nie jestem przekonany do tego jak to wygląda, alternatywą może być wstawienie zaokrąglonego prostokąta za nickiem z opacity .3 lub coś podobnego. No ale shadow i stroke dają taki średni efekt przy tak małej czcionce.