Skip to content

Add DisabledExtensions CA regsitry value #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonasBK wants to merge 1 commit into from
Open

Add DisabledExtensions CA regsitry value #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Runtime/ObjectProcessors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,7 @@
var enrollmentAgentRestrictionsCollected = false;
var isUserSpecifiesSanEnabledCollected = false;
var roleSeparationEnabledCollected = false;
var disabledExtensionsCollected = false;
var caName = entry.GetProperty(LDAPProperties.Name);
var dnsHostName = entry.GetProperty(LDAPProperties.DNSHostName);
if (caName != null && dnsHostName != null) {
Expand All @@ -834,6 +835,7 @@
EnrollmentAgentRestrictions = await _certAbuseProcessor.ProcessEAPermissions(caName,
resolvedSearchResult.Domain, dnsHostName, ret.HostingComputer),
RoleSeparationEnabled = await _certAbuseProcessor.IsRoleSeparationEnabled(dnsHostName, caName, ret.HostingComputer),
DisabledExtensions = await _certAbuseProcessor.DisabledExtensions(dnsHostName, caName, ret.HostingComputer),

Check failure on line 838 in src/Runtime/ObjectProcessors.cs

View workflow job for this annotation

GitHub Actions / build 

'CertAbuseProcessor' does not contain a definition for 'DisabledExtensions' and no accessible extension method 'DisabledExtensions' accepting a first argument of type 'CertAbuseProcessor' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 838 in src/Runtime/ObjectProcessors.cs

View workflow job for this annotation

GitHub Actions / build 

'CARegistryData' does not contain a definition for 'DisabledExtensions'

Check failure on line 838 in src/Runtime/ObjectProcessors.cs

View workflow job for this annotation

GitHub Actions / build 

'CertAbuseProcessor' does not contain a definition for 'DisabledExtensions' and no accessible extension method 'DisabledExtensions' accepting a first argument of type 'CertAbuseProcessor' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 838 in src/Runtime/ObjectProcessors.cs

View workflow job for this annotation

GitHub Actions / build 

'CARegistryData' does not contain a definition for 'DisabledExtensions'

// The CASecurity exist in the AD object DACL and in registry of the CA server. We prefer to use the values from registry as they are the ground truth.
// If changes are made on the CA server, registry and the AD object is updated. If changes are made directly on the AD object, the CA server registry is not updated.
Expand All @@ -845,6 +847,7 @@
enrollmentAgentRestrictionsCollected = cARegistryData.EnrollmentAgentRestrictions.Collected;
isUserSpecifiesSanEnabledCollected = cARegistryData.IsUserSpecifiesSanEnabled.Collected;
roleSeparationEnabledCollected = cARegistryData.RoleSeparationEnabled.Collected;
disabledExtensionsCollected = cARegistryData.DisabledExtensions.Collected;

Check failure on line 850 in src/Runtime/ObjectProcessors.cs

View workflow job for this annotation

GitHub Actions / build 

'CARegistryData' does not contain a definition for 'DisabledExtensions' and no accessible extension method 'DisabledExtensions' accepting a first argument of type 'CARegistryData' could be found (are you missing a using directive or an assembly reference?)

Check failure on line 850 in src/Runtime/ObjectProcessors.cs

View workflow job for this annotation

GitHub Actions / build 

'CARegistryData' does not contain a definition for 'DisabledExtensions' and no accessible extension method 'DisabledExtensions' accepting a first argument of type 'CARegistryData' could be found (are you missing a using directive or an assembly reference?)
ret.CARegistryData = cARegistryData;
} else {
_log.LogWarning("The CA name or dnsHostname properties are null.");
Expand All @@ -854,6 +857,7 @@
ret.Properties.Add("enrollmentagentrestrictionscollected", enrollmentAgentRestrictionsCollected);
ret.Properties.Add("isuserspecifiessanenabledcollected", isUserSpecifiesSanEnabledCollected);
ret.Properties.Add("roleseparationenabledcollected", roleSeparationEnabledCollected);
ret.Properties.Add("disabledextensionscollected", disabledExtensionsCollected);
}

return ret;
Expand Down
Loading