SR-87/Bugfix lint error counting #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update develop after 2.2.0 tagged
902seanryan
requested review from
TensAndTwenties,
corinnejean,
jeremymccurdy-redspace and
selenaqian
corinnejean
approved these changes
Mar 12, 2025
TensAndTwenties
approved these changes
Mar 12, 2025
902seanryan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it was an outdated signature but the results returned from
ESLint.lintFilesdoesn't have an errorCount attached to it. It's just an array of reports. Since we're manually checking each file for lint errors and sticking that in the results object we can check those reports. If they exist there were lint errors.