Update metadata+lockfiles to support testing pants-plugins/#5850
Merged
cognifloyd merged 5 commits intomasterfrom Dec 29, 2022
Merged
Update metadata+lockfiles to support testing pants-plugins/#5850cognifloyd merged 5 commits intomasterfrom
cognifloyd merged 5 commits intomasterfrom
Conversation
amanda11
approved these changes
Dec 19, 2022
85edb05 to
4488114
Compare
Eric-Arellano
approved these changes
Dec 22, 2022
nzlosh
approved these changes
Dec 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This is a follow-up for #5842 which configured pants to find plugins in
pants-plugins/.This PR consists of 4 updates:
testutils.interpreter_constraintsforpants-plugins/. I didn't realize that we had to configure this in bothpants.toml(which I did in Configure pants to look for plugins in pants-plugins/ directory #5842) and inpants-plugins/BUILD(which this PR adds).compileallMakefile target fails under python 3.6. So, I just excludepants-plugins/from that step in the Makefile.You can review each commit separately to see each of these items (lockfile regeneration is included in the commit that triggered the changes).