pants: use __defaults__ to propogate unit,integration,benchmarks tags on tests#5853
Merged
cognifloyd merged 3 commits intomasterfrom Dec 30, 2022
Merged
pants: use __defaults__ to propogate unit,integration,benchmarks tags on tests#5853cognifloyd merged 3 commits intomasterfrom
__defaults__ to propogate unit,integration,benchmarks tags on tests#5853cognifloyd merged 3 commits intomasterfrom
Conversation
77c7766 to
d5aa534
Compare
__defaults__ to propogate unit,integration,benchmarks tags on tests
Eric-Arellano
approved these changes
Dec 21, 2022
Eric-Arellano
left a comment
There was a problem hiding this comment.
FYI there's a gotcha that if you have any python_test targets rather than python_tests, they won't have the tags. That's probably unlikely you'll have that happen, but could. You can avoid the risk by using the key (python_test, python_tests)
Member
Author
Ah yes. Thanks for the pointer. Resolved. |
nzlosh
approved these changes
Dec 28, 2022
0755808 to
5d976d0
Compare
rush-skills
approved these changes
Dec 30, 2022
5d976d0 to
d4146a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This adjusts the BUILD metadata for all of our
python_teststargets so that they are tagged withunit,integration, orbenchmarks. We can add other tags when/if we find something that will be generally useful.Once we are able to run tests via pants, pants can use this to select a subset of tests to run. For example:
Check out the docs for more powerful examples of how to use tags on the command line.
Relevant pants docs