Merged
Conversation
And drop the pointless execute bit. The execute bit is only needed on the scripts in st2common/bin, not the underlying python files.
Make it clearer where things come from so tracking things down is easier.
in: - lockfiles/st2-constraints.txt - requirements-pants.txt
cognifloyd
requested review from
a team,
amanda11,
arm4b,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/S
nzlosh
approved these changes
Mar 8, 2023
arm4b
approved these changes
Mar 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This is a grab-bag of minor fixes I've noticed.
I would like to delete these - any objections? Do we need to worry about backwards compat for these internal-only bits?
st2common.persistence.reactorst2common.models.db.reactorcontrib/packs/tests/BUILDbecause it feels cleaner.requirements-pants.txtandlockfiles/st2-constraints.txt.st2common/st2common/cmd/*.py. These have no "main" check, so they're not directly executable. The real executables are inst2common/bin, and those do have the proper execute bit set.