Pants: reclassify test utils in BUILD metadata#5926
Merged
cognifloyd merged 5 commits intomasterfrom Mar 10, 2023
Merged
Conversation
…ot sources It makes more sense for the files in the tests directory to be "test_utils" instead of regular sources. It does not make a functional difference to pants, but I feel it captures the intent of those files better. The canonical example of "test_utils" is conftest.py which we might switch to later once we finish transitioning to pytest.
…ase.py as test_utils not sources
cognifloyd
requested review from
a team,
amanda11,
arm4b,
nzlosh,
rush-skills and
winem
pull-request-size
bot
added
the
size/S
arm4b
approved these changes
Mar 9, 2023
nzlosh
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This is another part of introducing pants, as discussed in various TSC meetings.
Related PRs can be found in:
Overview of this PR
This replaces a 4
python_sourcestargets withpython_test_utils. I excluded thetest_*.pyfiles intests/unitdirectories since those are already covered bypython_teststargets. I didn't bother to add that exclude inst2client/tests/BUILDhowever, because we keep our actual tests undertests/unitortests/integrationnot directly undertests/.Generally,
python_test_utilscaptures things likeconftest.pyfor pytest. Eventually, we might be able to replace these files with actualconftest.pyfiles once we finish migrating topytest. In any case, this makes more logical sense to me.This PR does not make any functional changes - to Pants,
python_sourcesandpython_test_utilsare functionally equivalent. So, this is a very minor/small PR.Pants documentation
python_test_utilstargetpython_sourcestarget