fix(index): render markdown properly and resolve relative image paths - #107
Merged
Conversation
Follow-up to #101. The original implementation wrapped all text file content in <pre> tags with html.escape(), so markdown syntax showed as raw text. This changes .md files to use the markdown library (with tables + fenced_code extensions) for proper rendering, while keeping <pre> for .txt files. Also rewrites relative src/href paths to absolute file:// URIs so local images load correctly during CDP rendering, and switches to TemporaryDirectory for automatic cleanup.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #101. Improves text file rendering in the index pipeline:
markdownlibrary (withtables+fenced_codeextensions) instead ofhtml.escape()+<pre>. Headings, tables, code blocks, links, and blockquotes all render correctly..txtfiles keep the<pre>wrapping.src/hrefattributes to absolutefile://URIs so local images (e.g.) load during CDP rendering.tempfile.mkdtemp()toTemporaryDirectorycontext manager.markdown>=3.4to theindexextra inpyproject.toml.Test plan
.txtfiles still render as monospace<pre>blocks