show the Preview button on every fixture - #1420
Merged
Merged
Conversation
added 2 commits
September 1, 2026 15:59
Most fixture rows showed only Download. The cause was FXWF, not PREVIEWS: it
filters which files appear per workflow, and 214 declared files across 37 modules
had no key, so they were hidden along with their Preview buttons. Previews already
existed for nearly all of them.
- add the 214 missing FXWF keys
- add 25 table previews for text fixtures that had none
- add 5 summaries for PLINK binary genotypes: variant and sample counts read
from the .bim and .fam, plus a few example rows. Reuses the existing rds kind
so no rendering code changes.
- add a summary for the multicontext QtlFineMappingResult
- add a note for vcf_qc/expected/qc_2.variants.tsv explaining that the file is
empty on purpose: GT-only variant QC removes every record on the toy data and
test_qc_2 pins that outcome. Filling it would break the regression guard.
- declare ld_prune_reference .bim, .fam and the .ld_genotype.list, which a glob
in the previous commit had dropped
266 of 267 fixture rows now offer Preview. The one exception is a .tbi tabix
index, a binary offset table with nothing readable to show.
The PLINK genotype summaries added in the previous commit reused the rds preview kind to avoid touching the render code, so a .bed opened under the heading "R object preview" - wrong, and it read as though a table were missing. Adds two preview kinds with their own headings: plink PLINK binary genotype - not a text table note File note and retags the 5 PLINK genotypes and the one intentionally empty fixture. The 43 genuine .rds files keep the R heading. Worth recording that .bed covers two unrelated formats: of the 17 .bed fixtures, 12 are text intervals and preview as tables, 5 are PLINK binary. Classification is by the 6c 1b 01 magic bytes, since matching on the extension reads the binaries as text and renders control characters. 230 of 231 fixture paths now have a preview; the exception is a .tbi tabix index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most fixture rows showed only Download because 214 files across 37 modules were missing from
FXWF, which controls which files appear for each workflow. Their previews mostly already existed.Two commits, two files.
What changed
FXWFkeys across 37 modules.ld_prune_referencefiles omitted by a glob.plinkandnotepreview kinds.230 of 231 fixture paths now have previews. The only exception is a binary
.tbiindex with no readable content.PLINK and empty-file handling
The builder now distinguishes text BED files from PLINK binary
.bedfiles using the6c 1b 01magic bytes. Binary files receive summaries based on their accompanying.bimand.famfiles instead of being rendered as text.tests/fixtures/vcf_qc/expected/qc_2.variants.tsvremains empty intentionally: the test asserts that all records are filtered out. Its preview now explains that behavior.Final preview counts:
table181,rds43,plink5,note1.Reviewer note
Most changed lines come from long embedded notebook data maps. The substantive changes are to
FXWF,PREVIEWS, and two rendering branches.