Default SuSiE L to 10 and greedy-L off - #1422
Merged
Merged
Conversation
The pipeline now defaults --L to 10 (was 20) and --L-greedy to none, so the greedy-L loop is off by default. Both stay overridable: pass --L N or --L-greedy N. Pairs with the matching pecotmr default change.
Yining97
force-pushed
the
rss-finemap-l-defaults
branch
from
September 3, 2026 19:12
e29e319 to
849a440
Compare
Yining97
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline defaults for the SuSiE fit:
Both stay overridable — pass --L N or --L-greedy N (a positive integer turns greedy back on). Pairs with the pecotmr default change.
Validated end to end on chr21 with both changes applied: a full SoS run at the new defaults completes, passing the old values (--L 20 --L-greedy 5) reproduces the pre-change fit exactly (PIP diff 0), and the new defaults fit 10 effects with greedy off.