Issue #284: enforce strict price-manager vs network-coordinator role … - #316
Closed
Killerjunior wants to merge 1 commit into
Closed
Issue #284: enforce strict price-manager vs network-coordinator role …#316Killerjunior wants to merge 1 commit into
Killerjunior wants to merge 1 commit into
Conversation
…k-coordinator role separation in price oracle
|
@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…separation in price oracle
Closes #284
Summary
This PR implements strict administrative boundary isolation for the contracts/price-oracle contract as required by issue #284.
What changed
Added explicit role separation between:
price managers (whitelisted providers allowed to submit verified prices)
network coordinators (authorized admins handling multisig/high-impact operations)
Updated set_price authorization so only dedicated price managers can submit verified price updates from external callers.
Preserved internal contract self-calls while enforcing provider-based authorization for external invokers.
Updated stored price metadata to record the actual submitting provider rather than always using the contract address.
Clarified contract storage comments to reflect the new dedicated price manager role.
Files changed
contracts/price-oracle/src/auth.rs
contracts/price-oracle/src/lib.rs
contracts/price-oracle/src/types.rs