Skip to content

Create a simple object to hold interview steps#108

Merged
nonprofittechy merged 25 commits into
mainfrom
workflow-registry
Jun 29, 2026
Merged

Create a simple object to hold interview steps#108
nonprofittechy merged 25 commits into
mainfrom
workflow-registry

Conversation

@nonprofittechy

@nonprofittechy nonprofittechy commented Jun 29, 2026

Copy link
Copy Markdown
Member

Adds a central filing workflow registry and view context. No template, JavaScript, persistence, or model changes.

This is a very minimalist version of the idea to make it easier to insert or remove steps in the LITeFile workflow. As is, there's no branching logic. A future version could use a state machine. Before a state machine, we should finalize a cleaner way to store interview state than the current randomly stashed keys into three different places.

It's also possible that linear is fine and a state machine isn't needed.

@nonprofittechy nonprofittechy requested a review from Copilot June 29, 2026 20:26
@nonprofittechy nonprofittechy changed the title Add central filing workflow registry Create a simple object to hold interview steps Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a centralized registry for the e-filing “wizard” steps and a helper to generate consistent per-step navigation context (current/previous/next + URLs), then wires that context into several existing filing views.

Changes:

  • Added efile_app/efile/workflow.py with a WorkflowStep registry and helpers for step lookup + prev/next navigation URL generation.
  • Updated filing views (options, upload_first, expert_form, payment) to merge the shared workflow context into their template context.
  • Removed duplicated login/token logic in options while adding the shared workflow context.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
efile_app/efile/workflow.py Adds the central workflow step registry and helper functions to compute navigation context/URLs.
efile_app/efile/views/options.py Injects workflow context into the options step (and cleans up duplicated logic).
efile_app/efile/views/upload_first.py Injects workflow context into the “upload lead document” step.
efile_app/efile/views/expert_form.py Injects workflow context into the “case information” step.
efile_app/efile/views/payment.py Injects workflow context into the payment step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread efile_app/efile/workflow.py Outdated
Comment thread efile_app/efile/workflow.py Outdated
Comment thread efile_app/efile/workflow.py Outdated
Comment thread efile_app/efile/workflow.py
Comment thread efile_app/efile/workflow.py Outdated

@BryceStevenWilley BryceStevenWilley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is I think this is a great start. I don't think we'd need to go all the way to state machine, but we might want conditional pages at some point? This def supports this with the current API though, so that's fine.

Comment thread efile_app/efile/workflow.py Outdated
Comment thread efile_app/efile/views/confirmation.py Outdated
@nonprofittechy nonprofittechy merged commit 18d4312 into main Jun 29, 2026
4 checks passed
@nonprofittechy nonprofittechy deleted the workflow-registry branch June 29, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants