Create a simple object to hold interview steps#108
Merged
Conversation
eb43875 to
8474c40
Compare
There was a problem hiding this comment.
Pull request overview
Introduces a centralized registry for the e-filing “wizard” steps and a helper to generate consistent per-step navigation context (current/previous/next + URLs), then wires that context into several existing filing views.
Changes:
- Added
efile_app/efile/workflow.pywith aWorkflowStepregistry and helpers for step lookup + prev/next navigation URL generation. - Updated filing views (
options,upload_first,expert_form,payment) to merge the shared workflow context into their template context. - Removed duplicated login/token logic in
optionswhile adding the shared workflow context.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| efile_app/efile/workflow.py | Adds the central workflow step registry and helper functions to compute navigation context/URLs. |
| efile_app/efile/views/options.py | Injects workflow context into the options step (and cleans up duplicated logic). |
| efile_app/efile/views/upload_first.py | Injects workflow context into the “upload lead document” step. |
| efile_app/efile/views/expert_form.py | Injects workflow context into the “case information” step. |
| efile_app/efile/views/payment.py | Injects workflow context into the payment step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BryceStevenWilley
approved these changes
Jun 29, 2026
BryceStevenWilley
left a comment
Contributor
There was a problem hiding this comment.
As is I think this is a great start. I don't think we'd need to go all the way to state machine, but we might want conditional pages at some point? This def supports this with the current API though, so that's fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a central filing workflow registry and view context. No template, JavaScript, persistence, or model changes.
This is a very minimalist version of the idea to make it easier to insert or remove steps in the LITeFile workflow. As is, there's no branching logic. A future version could use a state machine. Before a state machine, we should finalize a cleaner way to store interview state than the current randomly stashed keys into three different places.
It's also possible that linear is fine and a state machine isn't needed.