Repository navigation
Write menu items in sentence case - #475
Merged
Merged
Conversation
Remove view cone, Create lineup, Vision cone, Range outline, Inner outline, Inner fill, Range fill, Create folder, Create strategy and Set as default were the only title-case items left in the app's menus.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: test
"Remove View Cone" sat in title case right under the new "Detach view cone" in the agent menu. The app's menus use sentence case ("Copy to next page", "Edit placement", "Create caption"), so these items now do too:
Those were all the title-case labels left in
ShadContextMenuItems. Tests, driver scripts and comments that quote these labels are updated with them.Seen in a Windows driver build: the agent menu with a cone attached, KAY/O's ult menu, and the library's right-click menu, on main and on this branch (pictures above). The map theme menu wasn't opened.
Left alone: buttons, tabs and dialog titles use title case across the app ("New Strategy", "Create Strategy", "Log In", the "Create Lineup" dialog), so the library's "Create Strategy" button now sits above a "Create strategy" menu item. Changing those is a separate call.
The PR appears safe to merge; no actionable issues were found.Summary
Changes the remaining title-case menu labels to sentence case.
Reviews (1) · Last reviewed commit: "Write menu items in sentence case, like ..." · Reviewed by Greptile