Repository navigation
Remove windups (for now) - #31
Merged
Merged
Conversation
Which should have been removed a long time ago. It doesn't do anything, it was replaced by windups, and we certainly don't need it now that windups are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes windups due to technical debt. They are tightly coupled to everything, so it's hard to refactor other parts of the mod. They also run code asynchronously which talks to Minecraft, which is unsafe and prone to concurrency bugs (Minecraft is not thread safe).
I was actually working on refactoring windups to run synchronously, however the current design of them makes that difficult, and it wouldn't even solve the logical race conditions as we hold ServerPlayer objects over time, and a player may join/leave during that. We currently have defensive programming against the player leaving, however a cleaner approach for longer term is preferred.
If you are a user of the mod reading this PR, don't worry! Windups are coming back. This is a temporary removal whilst I focus on other parts of the mod.
The last commit with the old implementation of windups is here