Skip to content

waylandbridge: emit drag-and-drop drop before pointer release #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superturtlee merged 1 commit into from
Sep 28, 2026
Merged

waylandbridge: emit drag-and-drop drop before pointer release #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions services/waylandbridge/awl_input.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,14 +554,20 @@ static void tr_ptr_button(uint64_t win, uint32_t btn, uint32_t state) {
int tracked = (g_ptr_buttons & bit) != 0;
g_ptr_buttons &= ~bit;
g_ptr_grabbed &= ~bit;

/* End the compositor-owned DnD grab before forwarding the
* physical release. Firefox treats wl_pointer.button(released)
* as drag cancellation when it arrives before
* wl_data_device.drop: DOM sees pointerup/dragend, never drop,
* and the data offer remains unfinished. drop first matches
* the semantic end of the implicit grab; the later release is
* retained for Chromium, which needs the paired pointer event. */
awl_datadev_drag_end();

if (tracked) {
/* kwin seat.cpp pointer-release-during-drag: the drag button's
* release is forwarded to the pointer-focused surface before
* endDrag — the client ends its own drag session on it
* (chromium never finished the DnD handshake without it:
* no offer.finish, drag icon surface leaked, 2026-09-18
* "mouse drag stuck"). Untracked releases (no matching press
* went through the normal path) can't be paired → consumed. */
/* Keep the paired pointer release after the drop. Untracked
* releases (no matching press through the normal path) cannot
* be paired and are consumed. */
pthread_rwlock_rdlock(&g_srv.rwl);
struct awl_surface* s;
struct wl_resource* ptr = resolve(&g_ptrs, win, &s);
Expand All @@ -578,7 +584,6 @@ static void tr_ptr_button(uint64_t win, uint32_t btn, uint32_t state) {
}
pthread_rwlock_unlock(&g_srv.rwl);
}
awl_datadev_drag_end(); /* release = drop (KWin endDrag) */
}
return; /* presses during a drag are all consumed (implicit grab) */
}
Expand Down