[WIP] OP_WITHDRAWPROOFVERIFY implementation by Christewart · Pull Request #5 · Suredbits/bitcoin-s-sidechains

Christewart · 2017-03-14T18:14:57Z

This pull request implements the op code OP_WITHDRAWPROOFVERIFY found in the elements project.

The purpose of OP_WITHDRAWPROOFVERIFY is to support sidechains.

To see a detailed description of OP_WPV functionality please read this blog post:

https://medium.com/@Chris_Stewart_5/op-withdrawproofverify-the-op-code-that-powers-spv-sidechains-cefce996a324#.y2dcegslq

This pull request has a generator inside of it to test all cases that should be successful for OP_WPV. We test that generator produces only valid OP_WPV withdrawls here.
TODO:

Test generators for various failures of OP_WPV
Implement tweak_add functionality on the given contract

Modifying generators to be more flexible

Fixing bug in generator for merkle blocks with specific txs

Adding more flexibility to block header generators

Add merkle block

…hink it is all correct

… coins in the OP_WPV output when a user is not withdrawing all of them

Fixing bug in calculating pushops for ScriptNumberOperations

…iptNumberOperations -- for instance pushing an 83 byte transaction (whose op code is OP_3) -- whose script looks like OP_PUSHDATA1 OP_3 <83 byte tx> would fail before this

Fixing bug in pushing constants onto the stack whose op codes are Scr…

…ck to make sure withdrawl txs are valid

… those scripts

…pt_num_op Fixing bug in calculating pushops for ScriptNumberOperations

Christewart · 2017-03-14T18:19:16Z

src/main/scala/org/bitcoins/core/gen/ScriptGenerators.scala

+    (sidechainCreditingTx,outputIndex) = TransactionGenerators.buildSidechainCreditingTx(genesisBlockHash, reserveAmount)
+    sidechainCreditingOutput = sidechainCreditingTx.outputs(outputIndex.toInt)
+
+    contract = BitcoinSUtil.decodeHex("5032504800000000000000000000000000000000") ++ userSidechainAddr.bytes


Need to use generator here

Christewart · 2017-03-14T18:20:01Z

src/main/scala/org/bitcoins/core/gen/ScriptGenerators.scala



+  /** Generator for a contract used within a [[WithdrawScriptSignature]] */
+  def contract: Gen[Seq[Byte]] = for {


probably need to create a type for 'contract' and create a generator that takes in a Sha256Hash160Digest

Christewart · 2017-03-14T18:22:52Z

src/main/scala/org/bitcoins/core/script/crypto/CryptoInterpreter.scala

    */
  def opWithdrawProofVerify(program : ScriptProgram) : ScriptProgram = {
-    // comment from bitcoin core
+    require(program.script.headOption == Some(OP_WITHDRAWPROOFVERIFY), "Script operation is required to be OP_WITHDRAWPROOFVERIFY")


Need to implement the flag 'ScriptVerifyMinimalData`, this is implemented in elements but I haven't implemented yet in bitcoin-s-sidechains

Christewart · 2017-03-14T18:25:07Z

src/main/scala/org/bitcoins/core/script/crypto/CryptoInterpreter.scala

+  /** Checks the given [[MerkleBlock]] to see if we have enough proof of work
+    * [[https://github.com/ElementsProject/elements/blob/edaaa8b0f92653d9f770e671c7493f4bab4b48c7/src/pow.cpp#L40]]
+    * */
+  private def checkBitcoinProofOfWork(merkleBlock: MerkleBlock): Boolean = {


Implement this

Christewart · 2017-03-14T18:25:58Z

src/main/scala/org/bitcoins/core/script/crypto/CryptoOperations.scala


 case object OP_WITHDRAWPROOFVERIFY extends CryptoOperation {
  override def opCode = 179
+  override def toString = "OP_NOP4"


Add comment to why this is is set to OP_NOP4 and not OP_WPV, same with OP_NOP5

Christewart · 2017-03-14T18:26:49Z

src/main/scala/org/bitcoins/core/script/interpreter/ScriptInterpreter.scala

    val txSigComponent = program.txSignatureComponent
-    logger.debug("TxSigComponent: " + txSigComponent)
+    /** Helper function to check if the witness was used */
+    def witnessUsed(w: WitnessV0TransactionSignatureComponent) : Boolean = {


Consider moving this refactor upstream into bitcoin-s-core

Christewart · 2017-03-14T19:38:16Z

src/main/scala/org/bitcoins/core/gen/TransactionGenerators.scala

+    (scriptSig,scriptPubKey,fedPegScript,reserveAmount) <- ScriptGenerators.withdrawlScript
+    (sidechainCreditingTx,outputIndex) = buildSidechainCreditingTx(genesisBlockHash, reserveAmount)
+    sidechainCreditingOutput = sidechainCreditingTx.outputs(outputIndex.toInt)
+    sidechainUserOutput = TransactionOutput(scriptSig.withdrawlAmount,P2PKHScriptPubKey(scriptSig.userHash))


This is not always a P2PKHScriptPubKey, can be P2SHScriptPubKey depending on what the contract specifies.

Christewart · 2017-03-14T19:43:42Z

src/main/scala/org/bitcoins/core/protocol/script/ScriptSignature.scala

+      //TODO: Investigate this further, can we technically have negative output indexes as script numbers can be negative?
+      UInt32(num.toLong)
+    case constant: ScriptConstant =>
+      logger.error("Asm: " + asm)


remove this logger.error

Christewart · 2017-03-14T19:46:18Z

src/main/scala/org/bitcoins/core/script/crypto/CryptoInterpreter.scala

+    require(program.txSignatureComponent.isInstanceOf[FedPegTransactionSignatureComponent])
+    val fPegTxSigComponent = program.txSignatureComponent.asInstanceOf[FedPegTransactionSignatureComponent]
+
+    val relockScript: ScriptPubKey = ScriptPubKey(Seq(BytesToPushOntoStack(32),genesisHashToken, OP_WITHDRAWPROOFVERIFY))


Call WithdrawScriptPubKey constracut here instead of constructing the asm ourselves.

Christewart · 2017-03-14T19:47:53Z

src/main/scala/org/bitcoins/core/script/crypto/CryptoInterpreter.scala

+    val partialMerkleTree = merkleBlock.partialMerkleTree
+    val matchedTxs: Seq[DoubleSha256Digest] = partialMerkleTree.extractMatches
+
+    if (partialMerkleTree.tree.value != Some(merkleBlock.blockHeader.merkleRootHash) || matchedTxs.length != 1) {


Instead of != I think scala recommends using .contains()

Christewart · 2017-03-14T19:49:22Z

src/main/scala/org/bitcoins/core/script/crypto/CryptoInterpreter.scala

+      return ScriptProgram(program, ScriptErrorWithdrawVerifyOutputScriptDest)
+    }
+
+    val contractWithoutNonce = contract.take(4) ++ contract.slice(20,contract.length)


After creating a type for 'contract` create a method to access the user's hash

Christewart · 2017-03-14T20:13:30Z

src/test/scala/org/bitcoins/core/script/crypto/CryptoInterpreterTest.scala

+    val (sidechainCreditingTx,outputIndex) = buildSidechainCreditingTx(genesisBlockHash)
+    val sidechainCreditingOutput = sidechainCreditingTx.outputs(outputIndex)
+    val sidechainUserOutput = TransactionOutput(amount,P2PKHScriptPubKey(usersHash))
+    val relockScriptPubKey = ScriptPubKey.fromAsm(Seq(BytesToPushOntoStack(32),


Call WithdrawScriptPubKey.fromAsm

…nature, fixing first round of nits on OP_WPV pull request

Adding contract type to represent the contract in a WithdrawScriptSig…

Secp256k1 api enhancement

P2pkh script sig bug rd2

Christewart added 22 commits February 28, 2017 12:48

Adding new script error flags included in elements

74bb486

Preliminary implementation of OP_WPV - no testing done yet

1d0f68b

Modifying generators to be more flexible

878003c

Merge pull request #10 from Christewart/add_merkle_block

02d8f81

Modifying generators to be more flexible

Fixing bug in generator for merkle blocks with specific txs

510e65f

Merge pull request #11 from Christewart/add_merkle_block

a79ad19

Fixing bug in generator for merkle blocks with specific txs

Adding more flexibility to block header generators

bf2d9bb

Merge pull request #12 from Christewart/add_merkle_block

a74c6d3

Adding more flexibility to block header generators

Modifying merkle block generator to only include txs that are specfied

995cf92

Fixing bug

fe64c0e

Merge pull request #13 from Christewart/add_merkle_block

f8144d5

Add merkle block

Really rough implementation of OP_WPV, passes unit test but I don't t…

194ec0a

…hink it is all correct

Fixing bug where we were not checking that we were properly relocking…

1762a74

… coins in the OP_WPV output when a user is not withdrawing all of them

Fixing bug in calculating pushops for ScriptNumberOperations

6429007

Merge pull request #14 from Christewart/fix_calc_pushop_script_num_op

55e0cba

Fixing bug in calculating pushops for ScriptNumberOperations

Fixing bug in pushing constants onto the stack whose op codes are Scr…

a31439c

…iptNumberOperations -- for instance pushing an 83 byte transaction (whose op code is OP_3) -- whose script looks like OP_PUSHDATA1 OP_3 <83 byte tx> would fail before this

Merge pull request #15 from Christewart/fix_calc_pushop_script_num_op

b7e34d5

Fixing bug in pushing constants onto the stack whose op codes are Scr…

Implementing generator for withdrawl tx, implementing property to che…

73fe54b

…ck to make sure withdrawl txs are valid

Implementing WithdrawScriptSignature & WithdrawScriptPubKey represent…

690ea50

… those scripts

Adding properties for WithdrawScriptSignature and WithdrawScriptPubKey

02ff430

All unit tests passing for OP_WPV implementation

612c0e1

Merge pull request bitcoin-s#67 from Christewart/fix_calc_pushop_scri…

754b524

…pt_num_op Fixing bug in calculating pushops for ScriptNumberOperations

Christewart commented Mar 14, 2017

View reviewed changes

Christewart added 5 commits March 15, 2017 10:53

Adding contract type to represent the contract in a WithdrawScriptSig…

c921abc

…nature, fixing first round of nits on OP_WPV pull request

Fixing nits, adding some comments

30e1976

Adding way to automatically generate nonce for a Contract

b4dc2d0

Merge pull request #16 from Christewart/op_wpv_bug_fixes

a8c7ea1

Adding contract type to represent the contract in a WithdrawScriptSig…

Adding new secp256k1 functionality

979435a

Christewart added 5 commits March 23, 2017 09:27

Merge branch 'op_wpv' into secp256k1_api_enhancement

f5b566b

Merge pull request #17 from Christewart/secp256k1_api_enhancement

022f347

Secp256k1 api enhancement

Hopefully finally fixed the P2PKHScriptSignature bug

a67f477

Adding isFullyValid method to the ECPublicKey trait

26dfd81

Merge pull request #19 from Christewart/p2pkh_script_sig_bug_rd2

fb5333e

P2pkh script sig bug rd2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] OP_WITHDRAWPROOFVERIFY implementation#5

[WIP] OP_WITHDRAWPROOFVERIFY implementation#5
Christewart wants to merge 32 commits intoSuredbits:masterfrom
Christewart:op_wpv

Christewart commented Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Christewart Mar 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant



		/** Generator for a contract used within a [[WithdrawScriptSignature]] */
		def contract: Gen[Seq[Byte]] = for {

Conversation

Christewart commented Mar 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant