Skip to content

fix(web): remove blurOnTrigger from migration shortcuts #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Roshan1299 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(web): remove blurOnTrigger from migration shortcuts #1564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a6c529
fix(web): remove blurOnTrigger from migration shortcuts
Roshan1299 Mar 23, 2026
f8be81e
Merge branch 'main' into bug/fix-migration-shortcuts-1560
tyler-dane Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/web/src/views/Day/hooks/shortcuts/useDayViewShortcuts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ export function useDayViewShortcuts(config: KeyboardShortcutsConfig) {
handleMigrationNavigation("forward"),
{
ignoreInputs: false,
blurOnTrigger: true,
},
Comment on lines 171 to 173
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve pending title edits before task migration

If the user presses Ctrl+Meta+Arrow* while renaming a task, removing blurOnTrigger here means the input no longer blurs before handleMigrationNavigation calls onMigrateTask. In packages/web/src/views/Day/hooks/tasks/useTaskActions.ts, title edits live only in editingTitle until onInputBlur/Enter commits them, while migrateTask snapshots the task from tasks immediately; that causes the moved task, undo payload, and persisted move to use the stale title and silently drop the in-progress rename. The existing shortcut tests even cover migration while typing, so this path needs to commit the edit before migrating.

Useful? React with 👍 / 👎.

);

Expand All @@ -179,7 +178,6 @@ export function useDayViewShortcuts(config: KeyboardShortcutsConfig) {
handleMigrationNavigation("backward"),
{
ignoreInputs: false,
blurOnTrigger: true,
},
);

Expand Down