-
Notifications
You must be signed in to change notification settings - Fork 7
Maintenance/adobe edge/dependency #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@theoplayer/react-native-analytics-adobe-edge': patch | ||
| --- | ||
|
|
||
| Upgraded @adobe/alloy dependency to v2.35.0. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Alloy 2.35 runtime behaviour not verifiable in this checkout
AGENTS.md advises verifying third-party SDK behaviour against the pinned dependency in
node_modules/@adobe/alloy/dist/alloy.jsrather than from memory.node_modulesis not installed in this checkout, so the only assurance that the connector's usage ofcreateInstanceand the media tracker API (adobe-edge/src/internal/web/AdobeEdgeHandler.ts) is unchanged in 2.35.0 comes from the mocked jest suite, which does not exercise the real SDK. Worth confirming the package-level checks (cd adobe-edge && npm test,npm run typescript) were run against the upgraded dependency, since CI runs neither.Was this helpful? React with 👍 or 👎 to provide feedback.