Conversation
Added a new function to check the status of the datapusher and handle errors appropriately.
Implement datapusher status check and error handling
DP+ now records what it infers from a resource on that resource, rather than
overwriting a single dataset-level blob on every run. The popover therefore
has to decide, per field, how to combine what each resource inferred.
That decision is declared in the schema:
suggestion_policy: all_resources # offer every resource's answer
suggestion_policy: primary_resource # the default
Date Range wants every resource's range; the primary key and inferred extent
want the primary resource's only. _collectFieldSuggestions() gathers the
candidates accordingly and de-duplicates identical values.
The popover reuses the radio-list mode that already existed for CSVs with
several date columns, so multiple resources need no new UI. A resource whose
own suggestion holds several candidate columns still expands, now labelled
"resource > column".
Readers fall back to the dataset-level blob, so datasets analysed before this
change keep showing their suggestions and self-heal on re-analysis.
Refs TNRIS/texaswaterhub_CKAN#1088
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…pp-suggestions Combine suggestions across resources per a schema-declared policy (#1088)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.