Test the timestamp leeway boundary with mocked timers#38
Merged
Conversation
The happy path was previously bypassing the timestamp check with `leewayMinutes: 999999999` and the lone "not within allowed window" test relied on the fixture being years in the past, which only worked while real time kept marching forward. Replace with explicit boundary cases pinned to a fixed clock via `t.mock.timers`: - Happy path now uses the function's default leeway with the clock pinned to the moment the request was sent. - Four new cases cover exactly-at-boundary (passes) and one ms past the boundary (throws), in both the future and past directions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The happy path was previously bypassing the timestamp check with
leewayMinutes: 999999999, and the lone "not within allowed window" test relied on the fixture being years in the past — which only kept working while real time marched forward. Replace with explicit boundary cases pinned to a fixed clock viat.mock.timers:leewayMinuteswith the clock pinned to the moment the request was sent.Test plan
npm test— 19/19 pass.npm run lint— clean.🤖 Generated with Claude Code