Skip to content

Conversation

@nriley
Copy link
Contributor

@nriley nriley commented Dec 27, 2025

No description provided.

@netlify
Copy link

netlify bot commented Dec 27, 2025

Deploy Preview for talon-wiki-refactor ready!

Name Link
🔨 Latest commit 941dccc
🔍 Latest deploy log https://app.netlify.com/projects/talon-wiki-refactor/deploys/695fe1d24067200008d18ebf
😎 Deploy Preview https://deploy-preview-380--talon-wiki-refactor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nriley
Copy link
Contributor Author

nriley commented Dec 27, 2025

Going to try to commit for GitHub Pages deployment even though netlify is still stuck on an old Node version.

@nriley
Copy link
Contributor Author

nriley commented Dec 28, 2025

Update Slack — @2shea is currently on vacation, will work on upgrading the version of Node used by netlify. I think this should actually work fine on GitHub Pages when merged (but I can't merge my own PRs).

2shea and others added 2 commits January 8, 2026 08:52
…nd ghpages

Netlify allows specifying the node version using a .nvmrc file. This change
adds this file and also updates the github action for the bhpages build to use
this file. So, we only need to manage the node version in one place.
@2shea
Copy link
Contributor

2shea commented Jan 8, 2026

I confirmed in the Netlify logs that it's using a current version of Node: 8:58:42 AM: Now using node v24.12.0 (npm v11.6.2)

@2shea
Copy link
Contributor

2shea commented Jan 8, 2026

Update Slack — @2shea is currently on vacation, will work on upgrading the version of Node used by netlify. I think this should actually work fine on GitHub Pages when merged (but I can't merge my own PRs).

I updated this PR to use a .nvmrc file that's shared for both Netlify and GitHub pages. That way, we only need to manage the version in one place and removes the risk that they are out of sync.

Locally, I ran nvm use to verify the .nvmrc file is valid:

~/TalonCommunity/Wiki dependabot/npm_and_yarn/multi-0395cb5a69* ❯ nvm use                                                      09:06:01
Found '/Users/emilyshea/TalonCommunity/Wiki/.nvmrc' with version <lts/*>
Now using node v24.12.0 (npm v11.6.2)

The Netlify side looks good: 8:58:42 AM: Now using node v24.12.0 (npm v11.6.2)

I'll go ahead and merge. We should see github pages pull in the new version in the Github Actions run logs.

@2shea 2shea merged commit e72d7f2 into main Jan 8, 2026
5 checks passed
@2shea
Copy link
Contributor

2shea commented Jan 8, 2026

LGTM!

image

Thank you @nriley! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants