fix: declare python-dotenv dependency#996
Closed
AyushKar2005 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the python-dotenv dependency to pyproject.toml. The reviewer suggested adjusting the placement of this new dependency to maintain the alphabetical sorting of the dependencies list.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
22
to
+23
| "pytz>=2025.2", | ||
| "python-dotenv>=1.0", |
Member
|
Thanks @AyushKar2005. python-dotenv is already declared on main ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #994
This PR adds
python-dotenvas a direct runtime dependency.The CLI imports from
dotenvincli/utils.py, specificallyfind_dotenv,load_dotenv, andset_key. Butpython-dotenvwas not declared directly inpyproject.toml.Because of that, a clean install could fail at runtime with:
ModuleNotFoundError: No module named 'dotenv'if no transitive package happens to install it.
What changed
python-dotenv>=1.0topyproject.tomlWhy this helps
Since the CLI directly imports
dotenv, it should also declarepython-dotenvdirectly instead of relying on some other dependency to bring it indirectly.This makes clean installs more reliable.
Validation
I ran:
Result: