Superstructures#145
Conversation
dejabot
left a comment
There was a problem hiding this comment.
did you debate having superstructures be an attribute of Mechanism vs having Superstructure as a subclass of Mechanism (maybe with the ctor taking the constituent Mechanisms as arguments)? if so, curious about any rationale there. (you've thought about this a lot more - my initial instinct here would be to have Superstructure be a subclass, but I haven't thought through potential gotchas yet...)
c45557f to
136abd9
Compare
e7abdd1 to
dad9af2
Compare
136abd9 to
a6da2db
Compare
dad9af2 to
5f32fb1
Compare
a6da2db to
0004857
Compare
5f32fb1 to
b12b003
Compare
Talked through this offline. We're going to have a Superstructure base class, but do this: public class Arm extends Superstructure<...> {
...
public Arm() {
this.shoulder = addMechanism(new Shoulder());
this.elevator = addMechanism(new Elevator());
this.wrist = addMechanism(new Wrist());
}
...
} |
ad7d77a to
c6264db
Compare
b12b003 to
76d8c55
Compare
Description
Add support for encapsulating Mechanisms into superstructures.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Be detailed so that your code reviewer can understand exactly how much and what kinds of testing were done, and which might still be worthwhile to do.