Skip to content

[Nightly] Fix queue progress display in landscape mode - #13972

Merged
TobiGr merged 2 commits into
TeamNewPipe:devfrom
L1ly-Hou:fix/issue-13963
Oct 31, 2026
Merged

TobiGr merged 2 commits into
TeamNewPipe:devfrom
L1ly-Hou:fix/issue-13963

Conversation

@L1ly-Hou

Copy link
Copy Markdown
Contributor

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Fixed a crash in the Play Queue UI on rotation caused by the missing queue_total_duration view.
  • Added the queue progress display to the landscape layout.

Before/After Screenshots/Screen Record

  • Before: The Play Queue could crash in landscape orientation because the queue progress view was missing.
  • After:
screenshot

Fixes the following issue(s)

Devices
  • tested on a Pixel 6 Android12 emulator (API 31).
Steps for testing
  • Add multiple videos to the playback queue.

  • Open the Play Queue in portrait orientation and verify that the queue progress is displayed correctly.

  • Rotate the device to landscape orientation and verify that the Play Queue opens without crashing.

  • Switch between portrait and landscape orientations to verify that the layout remains functional.

APK for testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Oct 30, 2026
@TobiGr TobiGr added queue Issue is related to queueing regression A bug that didn't exist in prior versions but appeared after a certain change labels Oct 30, 2026
@TobiGr TobiGr added this to v0.29.x Oct 30, 2026
@github-project-automation github-project-automation Bot moved this to Todo in v0.29.x Oct 30, 2026

@TobiGr TobiGr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@TobiGr TobiGr self-assigned this Oct 30, 2026
@ShareASmile ShareASmile changed the title Fix queue progress display in landscape mode [Nightly] Fix queue progress display in landscape mode Oct 30, 2026
@sonarqubecloud

Copy link
Copy Markdown

@TobiGr TobiGr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@TobiGr
TobiGr merged commit 6d624c8 into TeamNewPipe:dev Oct 31, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in v0.29.x Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

queue Issue is related to queueing regression A bug that didn't exist in prior versions but appeared after a certain change size/small PRs with less than 50 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[nightly] UI crashes on rotation with NullPointerException in PlayQueueActivity

2 participants