[Ayush32-ai]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

This PR fixes duplicate videos being added to local playlists and improves how playlist items are updated.

• Added a check in PlaylistAppendDialog.java to prevent adding a video if it's already in the selected playlist. A Toast message is shown when the video is already there.
• Added cleanTimingFromUrl() in LocalPlaylistManager.kt to remove timestamp parameters from video URLs. This makes sure the same video is recognized even if it has a different start time, such as ?t=30s or #t=1m.
• Updated getPlaylistDuplicates() and appendToPlaylist() to check for duplicates before adding items to the database.
• Added unit tests for duplicate detection in LocalPlaylistManagerDuplicateTest.kt.
• Updated PlaylistFragment.java and LocalPlaylistFragment.java to use DiffUtil instead of refreshing the entire list whenever the data changes.
• Added InfoItemDiffCallback.kt and LocalItemDiffCallback.kt, along with tests for InfoItemDiffCallback.kt.
• Handled repeated stream URLs in InfoItemDiffCallback.kt using occurrence-based indexing so identical URLs are matched correctly and don't cause incorrect moves or index-related crashes.

Before/After Screenshots/Screen Record

• Before: Duplicate videos could be added to playlists, and refreshing the list could cause flickering or other issues.
• After: Duplicate additions are blocked, and playlist updates are handled more efficiently.

Fixes the following issue(s)

• Fixes Playlist crash when deleting a Video after fully watched #13971

Relies on the following changes

• None.

Testing/QA

Devices

• Nothing Phone (2a)

Steps for testing

• Added a video to a local playlist and tried adding it again to check that duplicates are blocked.
• Checked duplicate detection for URLs with different timestamp parameters.
• Tested playlist updates, including loading and pagination, to check that items are updated correctly.
• Ran the unit tests for duplicate detection and DiffUtil.

APK for testing

The debug APK is available under the Checks tab of the PR, in the CI artifacts.

Due diligence

• I read the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md).
• The proposed changes follow the [AI policy](https://github.com/TeamNewPipe/NewPipe/blob/HEAD/.github/CONTRIBUTING.md#ai-policy).
• I tested the changes using an emulator or a physical device.

[github-actions]

Please link this PR to an existing issue you are assigned to. This PR might be closed if the details of this PR were not agreed upon beforehand.

[Ayush32-ai]

@TobiGr Please check the code and pull request.

[Ayush32-ai]

@TobiGr suggestion regarding my pull request.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[TobiGr]

1. The PR contains tons of changes which are in no way related to the goal
2. The contents of the PR were not discussed beforehand
3. The PR contains more than one change
4. The PR and/or parts of the original PR description are AI generated.

We need to enfore strict contibution guidelines to keep the workload manageble.