Refactor Extractor#onFetchPage to not recieve downloader as parameter#1453
Open
dustdfg wants to merge 2 commits intoTeamNewPipe:devfrom
Open
Refactor Extractor#onFetchPage to not recieve downloader as parameter#1453dustdfg wants to merge 2 commits intoTeamNewPipe:devfrom
dustdfg wants to merge 2 commits intoTeamNewPipe:devfrom
Conversation
dustdfg
force-pushed
the
global_downloader
branch
from
0fc6892 to
07bfb23
Compare
Contributor
Author
|
Don't mind what just happened |
We have only one global downloader so there is not so much sense in passing it as parameter. Moreover Extractor class has getDownloader method which is used with globale Newpipe.getDownloader in half of the extracotrs. So before it any extractor could get downloader in 3 ways: downloader parameter, getDownloader and Newpipe.getDownloader now downloader parameter is eliminated. Moreover all 3 methods to access downloader always point to the same globale downloader
The downloader is global there is no sense to store reference to it in every instance of Extractor. So eliminate the field, make getDownloader shorthand for Newpipe.getDownloader and make it static to be accesible in static functions of extractors
dustdfg
force-pushed
the
global_downloader
branch
from
07bfb23 to
48b790f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔴 Breaking API change
Extractor.onFetchPagenow doesn't receive parameters