W9-design-handoff-Ylva Karlsson (NOT FINISHED)#49
Open
YlvaKarlsson wants to merge 12 commits into
Open
Conversation
cecavi
reviewed
Apr 16, 2023
cecavi
left a comment
There was a problem hiding this comment.
I think you have done a great job and your code is organized and the file structure is easy to follow. I see you have managed to do the styling in styled components, well done!
So cool that you have a styles folder with flex and global styling components. This is way above my knowledge for the moment and I might ask you more about this later on.
Considering that you have been sick and that we all are new to styled components I think you should be really proud. This was a very big project and I think you have a very good foundation to build on if you choose to do that at a later moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to sickness over Easter and the size of this project I was unable to even come close to finish. I'll try to accomplish something with this amazing design further on but hasn't been able to yet.
I hope in the future that you at Technigo really will think about the size of projects you give out - and specially at some week like Easter week (as you promised it would be a project at a size that we could manage).
Some students have managed - GREAT JOB of them :) But when we got the design so late and in that size... Some of us really had no fair chance to be able to accomplish this. Unfortunately I'm one of them. I've shown the project to my code-mentor and he is a fullstack-developer. Even he said it was to big of a project to be able to pull off by yourself in the short time given.
Sorry for this and I have no hard feelings regarding the UX-designer - the design was AWESOME. Just a bit too big for one person. This is something I really hope you can take with you for the future students and ofc I'll write this in my evaluation as well.