Skip to content

Project Happy Thoughts by Emma Engvall#445

Open
EmmaEngvall wants to merge 12 commits into
Technigo:masterfrom
EmmaEngvall:master
Open

Project Happy Thoughts by Emma Engvall#445
EmmaEngvall wants to merge 12 commits into
Technigo:masterfrom
EmmaEngvall:master

Conversation

@EmmaEngvall

Copy link
Copy Markdown

No description provided.

@codeandjazz codeandjazz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hej Emma!!

I'm gonna do this is english bc it's easier with all the complicated tech words and we both know...trying to translate them into swedish does NOT sound sexy at all :P

Comment thread code/src/App.js
setNewThought(event.target.value)
}

//Posting a new thought to the API

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good comment

const characterWarning = () => {
if (newThought.length > 140 ) {
return (
<p className="character-warning">You are trying to send too much love.</p>)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha too much love is apparently a thing-in this app, atleast

@codeandjazz codeandjazz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I accidentally submitted my review too early, nevermind the mess.

I loved seeing how closely you were able to follow the design and how incredibly functional your app is. It's doing everything it needs to do. One thing you could improve upon maybe is the responsiveness in mobile. At 320px, the thought form is being cropped quite drastically!

Your code is so clean, easy to read and nice to look at. Keep up the amazing work and I'm sure you will be building even more breathtakingly beautiful apps after the BC <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants