giorgio's happy thoughts#446
Open
GiorgioCugusi wants to merge 3 commits into
Open
Conversation
PerErikAndreas
left a comment
PerErikAndreas
left a comment
There was a problem hiding this comment.
Hi Giorgio!
First of all your page looks great! The CSS animations are really cool and its easy to follow in the comments what parts of the CSS your styling. Great work!
Review:
The page shows up like it should and did not crash or act strange in any situation that I could see. The requirements was to;
- List the most recent thoughts at the top (CHECK!)
- Your thoughts should show the content of the message and how many likes they've received (CHECK!)
- You should have a form to post new thoughts (CHECK!)
- You should implement the heart button to send likes on a thought (CHECK!)
The code is well-structured and you have named the different parts well.
I have left some single comments in the code! Great work Giorgio!
| ); | ||
| } | ||
| <> | ||
| <Background /> |
There was a problem hiding this comment.
This is a light and clean App.j!
| import ReactTimeAgo from 'react-time-ago'; | ||
| import NewPost from './NewPost.js'; | ||
|
|
||
| const API = 'https://happy-thoughts-ux7hkzgmwa-uc.a.run.app/thoughts' |
There was a problem hiding this comment.
This looks good and makes it easy to read in line 14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.