The todo - w.11 JL#437
Open
JohLeo wants to merge 19 commits into
Open
Conversation
jonsjak
reviewed
Apr 28, 2023
|
|
||
| const capitalizeFirstLetter = (str) => { | ||
| return str.charAt(0).toUpperCase() + str.slice(1); | ||
| } |
jonsjak
reviewed
Apr 28, 2023
| const onFormSubmit = (event) => { | ||
| event.preventDefault(); | ||
| const newNote = { | ||
| id: Date.now().toString(), |
There was a problem hiding this comment.
This id works for this project, but when building larger applications with multiple users there's a risk that two posts get the same id if posted at the same time. There are id-generators like uuid (npm package) that prevents this if you want to have look.
jonsjak
reviewed
Apr 28, 2023
jonsjak
left a comment
jonsjak
left a comment
There was a problem hiding this comment.
Nice app! Clean responsive design and it works as it should.
Very well structured, easy to follow with good naming and use of variables, components etc.
Because you assign variable names to the data you pass around the text doesn't get cluttered and repetitive. Good job!
One small comment on the design: Is the contrast on the buttons a bit hard to see (accessibility)?
PS. See additional comments in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://thetodo-jl.netlify.app