Repository navigation
fix(video): select AVC level for larger capture frames - #417
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear-quality recordings of taller or square tabs can fail before capture starts because the fixed H.264 level 4.2 codec allows fewer macroblocks than some frames within the 1920-pixel limit. For example, 1920x1152 is supported but 1920x1154 exceeds the limit after 16x16 edge padding.
Select baseline AVC level 5.0 only when the final, scaled frame exceeds level 4.2's 8,704-macroblock limit. Frames that already fit keep their existing encoding parameters. The change is confined to encoder configuration and regression coverage.
Validation:
The video CI job runs on Linux. The local test does not force or identify the encoder backend, so Windows MediaFoundation and macOS VideoToolbox hardware encoding remain unverified.
Follow-up to #412.