Skip to content

fix(global-images): quote model variable in LLM check - #1192

Open
cjb1234567 wants to merge 1 commit into
TencentCloud:feat/server_teamfrom
cjb1234567:codex/fix-global-images-utf8-model-variable
Open

fix(global-images): quote model variable in LLM check#1192
cjb1234567 wants to merge 1 commit into
TencentCloud:feat/server_teamfrom
cjb1234567:codex/fix-global-images-utf8-model-variable

Conversation

@cjb1234567

Copy link
Copy Markdown

Summary

Fixes the interactive start-all.sh LLM connectivity check under UTF-8 locales by using ${model} before full-width Chinese punctuation.

Without braces, Bash with set -u can parse the punctuation as part of the variable name when the configured model is absent from the OpenAI /models response, terminating the startup flow with an unbound-variable error.

Validation

  • Reproduced the original failure using a mocked HTTP 200 /models response without the configured model.
  • Re-ran the same reproduction after the change; it completes successfully.
  • Ran bash -n deploy/global-images/_lib.sh deploy/global-images/start-all.sh.

Closes #1191.

@Maxwell-Code07

Copy link
Copy Markdown
Collaborator

Thank you so much for your attention and contribution! We will arrange an internal review for this PR shortly, and all feedback will be shared right here in the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(global-images): quote model variable before Chinese punctuation

2 participants