fix(global-images): quote model variable in LLM check - #1192
Open
cjb1234567 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thank you so much for your attention and contribution! We will arrange an internal review for this PR shortly, and all feedback will be shared right here in the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the interactive
start-all.shLLM connectivity check under UTF-8 locales by using${model}before full-width Chinese punctuation.Without braces, Bash with
set -ucan parse the punctuation as part of the variable name when the configured model is absent from the OpenAI/modelsresponse, terminating the startup flow with an unbound-variable error.Validation
/modelsresponse without the configured model.bash -n deploy/global-images/_lib.sh deploy/global-images/start-all.sh.Closes #1191.