fix(proxy): register pi in AGENT_PREFIX_RE - #1195
Open
san-tian wants to merge 1 commit into
Open
Conversation
The first-class pi adapter (TencentCloud#1126) handles /pi/{spaceId}/v1/... requests, but AGENT_PREFIX_RE still lacks "pi", so cost-guard / analyse markers on /pi paths are not recognized and whitelist matching misses. Add "pi" to the agent alternation and cover normalization + marker + whitelist-matching paths with vitest tests. Signed-off-by: san-tian <admin@macaron.xin>
Collaborator
|
Thank you so much for your attention and contribution! We will arrange an internal review for this PR shortly, and all feedback will be shared right here in the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1126 (first-class Pi adapter). That PR added the
piagent adapter but leftAGENT_PREFIX_REwithoutpi, so/pi/{spaceId}/v1/...requests are not prefix-stripped and cost-guard / analyse markers on/pipaths are not recognized (whitelist matching misses).This PR is the minimal change:
pito theAGENT_PREFIX_REalternation (one line)/pi/v1/messagesand/pi/{spaceId}/v1/...normalization/pipaths/pipathsTest
Supersedes #1062.