Merged
Conversation
Contributor
Author
|
guys review quick or i will merge |
Contributor
|
no need of the trophy reaction imo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
counting.py
Describe the change in 2–5 sentences.
Fixed the counting high-score reaction bug by stopping the bot from ever removing ✅/🏆 reactions when a new high score is reached (or when the count gets ruined/reset). Now reactions are additive-only: once the bot adds ✅/🏆 to a counting message, it won’t “uncheck” or “untrophy” it later.
What changed: Removed the “keep only one active highscore marker” behavior that stripped ✅/🏆 from the previous record message
Why?
#38
Link the issue (required for non-trivial changes):
How to test
lol bot is already running.
Provide copy/paste commands and expected output.
Checklist
.env, keys)Screenshots (optional)