Fix authentication format and calendar date handling by TheEagleByte · Pull Request #21 · TheEagleByte/skylight-mcp

TheEagleByte · 2025-12-30T15:25:00Z

Summary

Fix email/password authentication: Changed from Bearer token to Basic base64(userId:token) format, which is what the Skylight API actually expects
Fix calendar events query: The API treats date_max as exclusive, so querying a single day (e.g., 2025-12-30 to 2025-12-30) returned no events. Now we add 1 day to date_max to include events on the end date
Add debug logging: Added logging for auth flow to help troubleshoot login issues
Add automatic retry: For email/password auth, automatically retry once on 401 errors by re-logging in

Test plan

Verify email/password login works correctly
Verify get_calendar_events returns events for a single day
Verify calendar events for date ranges work correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Fixed calendar event retrieval to correctly include the end date in results
- Added automatic retry on temporary authentication failures to reduce manual re-login requirements
Changes
- Updated authentication protocol to use improved security methods
- Enhanced error messaging for better troubleshooting of authentication issues

_{✏️ Tip: You can customize this high-level summary in your review settings.}

- Fix email/password auth to use Basic base64(userId:token) format - Fix calendar events query to treat date_max as exclusive (add 1 day) - Add debug logging for auth flow - Add automatic retry on 401 for email/password auth - Bump version to 1.1.7 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

coderabbitai · 2025-12-30T15:25:08Z

📝 Walkthrough

Walkthrough

Version 1.1.7 updates the authentication mechanism from Bearer token to Basic auth using base64-encoded userId:token pairs, adds debug logging throughout the auth flow, implements automatic retry on 401 errors for email/password authentication, and adjusts calendar event date handling to treat date_max as inclusive.

Changes

Cohort / File(s)	Summary
Release & Versioning `CHANGELOG.md`, `package.json`	Version bumped to 1.1.7 with changelog entry documenting authentication mechanism change, debug logging, and automatic 401 retry for email/password auth.
Authentication Core `src/api/auth.ts`, `src/api/client.ts`	Auth switched from Bearer to Basic auth (base64 userId:token). Added credential tracking (userId + token), debug logging, 401 error handling with detailed messages. Request flow now includes isRetry flag; email/password auth retries once on 401 before failing.
Calendar Endpoint `src/api/endpoints/calendar.ts`	Added internal date adjustment helper; getCalendarEvents now treats date_max as inclusive by adding 1 day before API call.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant Client as SkylightClient
    participant Auth as Auth Service
    participant API as API Server

    User->>Client: request(endpoint)
    Client->>Client: request(endpoint, {}, false)
    
    alt Email/Password Mode
        Client->>Client: getCredentials()
        Client->>Auth: login(email, password)
        Auth->>API: POST /login
        API-->>Auth: {token, userId}
        Auth-->>Client: {token, userId}
        Client->>Client: getAuthHeader() → Basic auth
    else Token/Basic Mode
        Client->>Client: getCredentials()
        Client->>Client: getAuthHeader() → existing auth
    end

    Client->>API: GET endpoint<br/>(with auth header)
    
    alt 401 Response
        API-->>Client: 401 Unauthorized
        alt Email/Password + !isRetry
            rect rgb(255, 240, 245)
                Note over Client: Retry Flow
                Client->>Client: clearCredentials()
                Client->>Auth: login(email, password)
                Auth->>API: POST /login
                API-->>Auth: {token, userId}
                Auth-->>Client: {token, userId}
                Client->>Client: getAuthHeader() → Basic auth
                Client->>Client: request(endpoint, {}, true)
                Client->>API: GET endpoint<br/>(retry with new token)
            end
        else Other Auth Mode OR isRetry=true
            Client->>Client: handleResponseError(401)
            Client->>User: throw AuthenticationError
        end
    else Success
        rect rgb(245, 255, 240)
            Note over Client: Request Succeeds
            API-->>Client: Response
            Client-->>User: Return data
        end
    end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

🐰 A hop, skip, and jump through the auth-scape we go,
With Basic credentials in base64's glow!
When 401 strikes, we retry with grace,
No token left behind in this secure place,
Calendar dates now inclusive and bright—
Version 1.1.7 sets everything right! 🔐✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly captures the two main fixes in the changeset: authentication format change and calendar date handling correction.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/api/endpoints/calendar.ts (1)
22-26: Potential timezone edge case in date parsing.

Using new Date(dateStr + "T00:00:00") parses the date in the local system timezone, which could cause unexpected results near DST transitions or on servers in different timezones. Consider parsing as UTC for consistent behavior:
🔎 Proposed fix for timezone-safe parsing
 function addDays(dateStr: string, days: number): string {
-  const date = new Date(dateStr + "T00:00:00");
-  date.setDate(date.getDate() + days);
-  return date.toISOString().split("T")[0];
+  const date = new Date(dateStr + "T00:00:00Z");
+  date.setUTCDate(date.getUTCDate() + days);
+  return date.toISOString().split("T")[0];
 }

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0acfc20 and ed541f7.

📒 Files selected for processing (5)

CHANGELOG.md
package.json
src/api/auth.ts
src/api/client.ts
src/api/endpoints/calendar.ts

🧰 Additional context used

📓 Path-based instructions (1)

**/*.ts

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.ts: Use npm run build to compile TypeScript
Configure TypeScript with ES2022 target, NodeNext module resolution, and strict mode

Files:

src/api/auth.ts
src/api/endpoints/calendar.ts
src/api/client.ts

🧠 Learnings (5)