bugfix(controlbar): Show shortcut special powers in Generals again

[xezon]

• Follow up for unify(controlbar): Merge ControlBar and related code from Zero Hour #2655

#2655 broke the Shortcut special powers in Generals. Reason being, Generals does not have the "ShortcutPower" flags set in the INI files.

To support the legacy setup, Generals is satisfied with the presence of the command center again.

[greptile-apps]

Greptile Summary

This PR restores the shortcut special powers bar in vanilla Generals by introducing canShowSpecialPowerShortcut(), a new helper that — under #ifdef RTS_GENERALS — falls back to checking for a command center rather than requiring the ShortcutPower INI flag that Generals never sets. The Zero Hour (GeneralsMD) build carries the same new function but the #ifdef block is inactive there, so its behavior is unchanged.

Confidence Score: 4/5

Safe to merge; only a minor style inconsistency found.

The logic is correct and well-scoped. The only finding is a P2 style issue (lowercase true/false vs the codebase-standard TRUE/FALSE). No logic bugs or regressions were identified.

No files require special attention beyond the style note in both ControlBar.cpp copies.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Include/GameClient/ControlBar.h	Moves hasAnyShortcutSelection() and adds canShowSpecialPowerShortcut() declaration to the public section, grouped with the other shortcut methods.
Generals/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp	Adds canShowSpecialPowerShortcut() which uses #ifdef RTS_GENERALS to fall back to a command-center presence check; simplifies updateSpecialPowerShortcut and showSpecialPowerShortcut to use the new helper. Minor style inconsistency: lowercase true/false vs codebase-wide TRUE/FALSE.
GeneralsMD/Code/GameEngine/Include/GameClient/ControlBar.h	Mirrors the Generals header change: moves hasAnyShortcutSelection() and adds canShowSpecialPowerShortcut() to the public shortcut method group.
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp	Identical delta to the Generals CPP; #ifdef RTS_GENERALS inside canShowSpecialPowerShortcut() is intentionally inactive for Zero Hour, so behavior is unchanged there. Same true/false style inconsistency.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["updateSpecialPowerShortcut() / showSpecialPowerShortcut()"] --> B["canShowSpecialPowerShortcut()"]
    B --> C{{"#ifdef RTS_GENERALS"}}
    C -- "Generals build" --> D["findNaturalCommandCenter() != nullptr?"]
    D -- "yes" --> E["return true (show bar)"]
    D -- "no" --> F["hasAnyShortcutSelection()?"]
    C -- "Zero Hour build" --> F
    F -- "yes" --> E
    F -- "no" --> G["hasAnyShortcutSpecialPower()?"]
    G -- "yes" --> E
    G -- "no" --> H["return false (hide bar)"]

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
Generals/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBar.cpp:3558-3574
**Inconsistent bool literal style**

The new `canShowSpecialPowerShortcut()` returns lowercase `true`/`false`, while every surrounding function in the same file (e.g. `hasAnyShortcutSelection()` returning `TRUE`/`FALSE`) uses the codebase-wide uppercase constants. The same inconsistency exists in the `GeneralsMD` copy of this function.

_{Reviews (1): Last reviewed commit: "Improve comment text" | Re-trigger Greptile}