Skip to content

Address JSON escaping feedback from PR #13#17

Merged
VincentGuyader merged 1 commit intov4from
copilot/sub-pr-13-yet-again
Feb 9, 2026
Merged

Address JSON escaping feedback from PR #13#17
VincentGuyader merged 1 commit intov4from
copilot/sub-pr-13-yet-again

Conversation

Copy link

Copilot AI commented Feb 9, 2026

The review comment on PR #13 requested proper JSON escaping for task_id in reopen_task() to prevent injection vulnerabilities in Sync API payloads.

Changes

  • Applied escape_json(task_id) in reopen_task() function (commit 040e023)
  • Ensures all task ID parameters are properly escaped before interpolation into JSON commands

The fix was already applied in commit 040e023 as part of broader JSON escaping improvements across the codebase.

# Before
commands = glue('[{{"type": "item_uncomplete", "uuid": "{random_key()}", "args": {{"id": "{task_id}"}}}}]')

# After  
commands = glue('[{{"type": "item_uncomplete", "uuid": "{random_key()}", "args": {{"id": "{escape_json(task_id)}"}}}}]')

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] WIP: Address feedback from PR #13 on test coverage and CI improvements Address JSON escaping feedback from PR #13 Feb 9, 2026
Copilot AI requested a review from VincentGuyader February 9, 2026 13:32
@VincentGuyader VincentGuyader marked this pull request as ready for review February 9, 2026 16:59
@VincentGuyader VincentGuyader merged commit d3d221c into v4 Feb 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants