Skip to content

Confirm JSON escaping fixes already applied in PR #13#23

Closed
Copilot wants to merge 1 commit intov4from
copilot/sub-pr-13-63234856-54a1-40f3-9ccc-84c50807936d
Closed

Confirm JSON escaping fixes already applied in PR #13#23
Copilot wants to merge 1 commit intov4from
copilot/sub-pr-13-63234856-54a1-40f3-9ccc-84c50807936d

Conversation

Copy link

Copilot AI commented Feb 10, 2026

Review feedback requested JSON escaping fixes for Sync API commands to prevent malformed payloads. All requested changes were already applied in commits 040e023 and 830ea10.

Changes Already Applied

Functions now using escape_json() for string interpolation:

  • update_workspace() - escapes workspace_id
  • close_task() - escapes task_id
  • reopen_task() - escapes task_id
  • delete_collaborator() - escapes project_id, email
  • delete_invitation() - escapes invitation_id
  • delete_task() - escapes task_id

Example

Before:

commands = glue('[{{"type": "item_close", "uuid": "{random_key()}", "args": {{"id": "{task_id}"}}}}]')

After:

commands = glue('[{{"type": "item_close", "uuid": "{random_key()}", "args": {{"id": "{escape_json(task_id)}"}}}}]')

This prevents JSON injection when IDs contain quotes, backslashes, or control characters.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Improve test coverage, fix bugs, and update CI Confirm JSON escaping fixes already applied in PR #13 Feb 10, 2026
Copilot AI requested a review from VincentGuyader February 10, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants