Skip to content

feat(metrics): add opentelemetry support#575

Open
ahkui wants to merge 4 commits intoThreeDotsLabs:masterfrom
ahkui:metrics/opentelemetry
Open

feat(metrics): add opentelemetry support#575
ahkui wants to merge 4 commits intoThreeDotsLabs:masterfrom
ahkui:metrics/opentelemetry

Conversation

@ahkui
Copy link
Copy Markdown

@ahkui ahkui commented May 26, 2025

Signed-off-by: ahkui ahkui@outlook.com

#574

Motivation / Background

Implement metrics collection using the OpenTelemetry MeterProvider

Detail

Implement metrics collection using the OpenTelemetry MeterProvider

Alternative approaches considered (if applicable)

Checklist

The resources of our team are limited. There are a couple of things that you can do to help us merge your PR faster:

  • I wrote tests for the changes.
  • All tests are passing.
    • If you are testing a Pub/Sub, you can start Docker with make up.
    • You can start with make test_short for a quick check.
    • If you want to run all tests, use make test.
  • Code has no breaking changes.
  • (If applicable) documentation on watermill.io is updated.

Signed-off-by: ahkui <ahkui@outlook.com>

ThreeDotsLabs#574
@ahkui ahkui force-pushed the metrics/opentelemetry branch from a1f41a2 to 5470970 Compare May 26, 2025 16:58
Signed-off-by: ahkui <ahkui@outlook.com>

ThreeDotsLabs#574
@ahkui
Copy link
Copy Markdown
Author

ahkui commented May 28, 2025

Hi @roblaszczak and @m110,

Could you please help review this PR when you have a moment?

Thanks!

Signed-off-by: ahkui <ahkui@outlook.com>
@ahkui ahkui force-pushed the metrics/opentelemetry branch from 4182b09 to c51f8a9 Compare June 3, 2025 08:34
@roblaszczak
Copy link
Copy Markdown
Member

We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476

To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.

I would moving those changes to a separate components/opentelemetry package.

Do you feel you'll have time for that @ahkui? Let us know!

@ahkui
Copy link
Copy Markdown
Author

ahkui commented Sep 18, 2025

We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476

To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.

I would moving those changes to a separate components/opentelemetry package.

Do you feel you'll have time for that @ahkui? Let us know!

@roblaszczak yes, i can handle that

the new pkg i will move to components/metrics/opentelemetry, do you have other suggestion for the location ?

@roblaszczak
Copy link
Copy Markdown
Member

We had this issue with OpenTelemtry in many projects: open-telemetry/opentelemetry-go#4476
To avoid that it would be good to move OpenTelemetry implementation to a separate package, with a separate go.mod. So the main go.mod won't be affected.
I would moving those changes to a separate components/opentelemetry package.
Do you feel you'll have time for that @ahkui? Let us know!

@roblaszczak yes, i can handle that

the new pkg i will move to components/metrics/opentelemetry, do you have other suggestion for the location ?

Hey, I discussed it with @m110 and since it looks orthogonal to the metrics package we can keep it flat (keeping it in sub-directory would suggest that it depends on metrics).

So I would suggest components/opentelemetry. It will be also easier to find :-)

@Thorleon
Copy link
Copy Markdown

Thorleon commented Jan 6, 2026

Hey @ahkui and @roblaszczak, I would love to have OTEL metrics in Watermill, do you need any help to finalize this Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants