#1188 Enhance the IDownstreamRouteProvider service by implementing virtual behavior

[mantasaudickas]

Closes #1188

• Add a possibility to change service name dynamically because of Consul tags #1188

Proposed Changes

• separate GetServiceName method into own class with interface
• use that class to find service name when needed
• gives possibility to library users to override existing behavior (for example choose service based on path and Consul tags)

[raman-m]

Hi Mantas!
Thank for your interest in Ocelot!

I cannot resolve conflicts using GitHub UI, it is unclear what to do...

Could you resolve merge conflicts please?
I've created a couple of PRs in your repo.

---

P.S. Zalgiris Kaunas basketball forever! 🤣 🏀

[mantasaudickas]

To be honest - I do not remember anything here what was here done :)
So I guess it simply can be closed without integrating it :)

[raman-m]

Nooo-oo!
Why don't you wish to fight for your solution and feature #1188 delivery?
Come on!
Are you still C# developer?

And Mantas,
I don't see develop branch in your fork! Your fork is too old.

Could you Sync fork please? So, new develop branch will occur with all top commits!

---

If Sync fork button won't help to make develop branch as default one,
Run this script please:

git remote add upstream https://github.com/ThreeMammals/Ocelot.git // add original repo as upstream remote
git fetch upstream                                                 // pull changes from original repo
git checkout -b develop upstream/develop                           // pull down develop branch locally
git push -u origin develop                                         // push develop branch to fork

Don't forget to make develop as default branch in GitHub.
Let me know updating results please!

[raman-m]

Hi Mantas!
I thought you need some help with resolving of merge conflicts...
Congrats! 🎉 I've resolved all merge conflicts!

The feature branch has been rebased onto ThreeMammals:develop!

Could you add me as collaborator to your forked repo please? I will create develop branch and make it default.

Now we can go with code review...
And we will start discussion of the issue (#1188) soon...

[mantasaudickas]

I have added you as collaborator. Sorry, just have no time to handle all these things here at the moment as we also do not use Ocelot in our infrastructure because it was not matching our needs.