fix: use uname -m for architecture detection#9
Conversation
The HOSTTYPE/MACHTYPE environment variables can be incorrect in some environments (e.g., GitHub Codespaces), causing arm64 machines to try to run x86_64 binaries. Now prioritizes uname -m for reliable architecture detection.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Go bootstrap script now unconditionally retrieves the machine architecture via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
Problem
In GitHub Codespaces (and possibly other environments),
MACHTYPEis incorrectly set tox86_64even when running on arm64. This causes the launcher script to try to run the wrong binary, resulting in "Exec format error".Solution
Prioritize
uname -mfor architecture detection instead of relying onHOSTTYPE/MACHTYPEenvironment variables.