Support Public Key Algorithms in Crypto Module#80
Open
InfoHunter wants to merge 19 commits intoTongsuo-Project:mainfrom
Open
Support Public Key Algorithms in Crypto Module#80InfoHunter wants to merge 19 commits intoTongsuo-Project:mainfrom
InfoHunter wants to merge 19 commits intoTongsuo-Project:mainfrom
Conversation
Member
Author
|
Tongsuo will fail for sure since its adaptor is not implemented yet |
added 11 commits
January 8, 2025 19:28
InfoHunter
changed the title
wa5i
requested changes
Mar 3, 2025
| prime: Option<u8>, | ||
| size: Option<RSAKeySize>, | ||
| ) -> Result<Self, RvError> { | ||
| return Ok( |
| let mut ctx = match PkeyCtx::new(&key) { | ||
| Ok(ctx) => ctx, | ||
| Err(_e) => return Err(RvError::ErrCryptoPKeyInternalError), | ||
| }; |
Collaborator
There was a problem hiding this comment.
let mut ctx = PkeyCtx::new(&key).map_err(|_| RvError::ErrCryptoPKeyInternalError)?;
| let rsa = match Rsa::generate(bits) { | ||
| Ok(r) => r, | ||
| Err(_e) => return Err(RvError::ErrCryptoPKeyRSAKeyGenFailed), | ||
| }; |
Collaborator
There was a problem hiding this comment.
let rsa = Rsa::generate(bits).map_err(|_| RvError::ErrCryptoPKeyRSAKeyGenFailed)?;
| let pkey = match PKey::from_rsa(rsa) { | ||
| Ok(r) => r, | ||
| Err(_e) => return Err(RvError::ErrCryptoPKeyRSAKeyGenFailed), | ||
| }; |
Collaborator
There was a problem hiding this comment.
let pkey = PKey::from_rsa(rsa).map_err(|_| RvError::ErrCryptoPKeyRSAKeyGenFailed)?;
| match ctx.verify_init() { | ||
| Ok(_ret) => {}, | ||
| Err(_e) => return Err(RvError::ErrCryptoPKeyVerifyInitFailed), | ||
| } |
| let valid = match ctx.verify(data, sig) { | ||
| Ok(ret) => ret, | ||
| Err(_e) => return Err(RvError::ErrCryptoPKeyVerifyFailed), | ||
| }; |
| #[cfg(feature = "crypto_adaptor_tongsuo")] | ||
| #[test] | ||
| fn test_sm2_keygen() { | ||
| assert_eq!(1, 1); |
Member
Author
There was a problem hiding this comment.
SM2 is not to be supported in this PR. rust-tongsuo should support SM2 first.
| #[cfg(feature = "crypto_adaptor_tongsuo")] | ||
| #[test] | ||
| fn test_sm2_sign_decrypt() { | ||
| assert_eq!(1, 1); |
| #[cfg(feature = "crypto_adaptor_tongsuo")] | ||
| #[test] | ||
| fn test_sm2_encrypt_decrypt() { | ||
| assert_eq!(1, 1); |
Member
Author
There was a problem hiding this comment.
This not implemented in the underlying rust-tongsuo crate, so it's not implemented yet.
|
Paul Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Algorithms may vary for different crypto adaptor: