Adding in first run at the docker files#156
Conversation
|
As promised, Dockerfiles with complete instructions are now here. @ToyKeeper - When you have time, please review. I will make any changes to suit your needs. I don't know who else has approval rights here. |
|
FYI There are already some docker environments for building Anduril, such as https://github.com/SammysHP/anduril-buildenv-docker/tree/new-build-system https://github.com/SiteRelEnby/anduril-buildenv-docker They were specifically optimized for FSM because some compiler and library versions compile better code for this project. |
|
Sorry. It has been a while since I've had some time for some night time coding. I understand that dockerfiles exist elsewhere, but in proper fashion each version of the docker file may change WITH the code. This means that the dockerfiles may be out of sync with what the code needs. It is in best practice to tie these together considering that this project is very small at this time, and dockerfiles are small and inconsequential in the grand scheme of things. This is infrastructure as code. I will be willing to accept one of those alternatives proposed above INTO this repository because that is in my opinion a GOOD thing. We can work on it together and amalgamate / conglomerate those docker files here. Can we start off with ground zero? I have a working, and documented proposal here. We can then integrate other portions from either of the above repositories, or maybe one of you can put up a PR here, we'll adopt yours from ground zero. |
|
Hi, thanks for the contribution. There are already some nice solutions for building Anduril with Docker, for folks who want to do it that way. If I was using Docker and building with it, I would have merged one of the existing solutions a long time ago. But as is, it is an extra complication that I wouldn't test or maintain or really even think about, so it would likely break on a regular basis. So it is probably better maintained externally. However, I just realized I forgot to add the Docker links to the README, so ... I'm at least going to fix that. There's the repo from SammysHP, the repo from SiteRelEnby, and if you can modify yours to be a standalone repo with just the Docker stuff and not the rest of the Anduril code, I can add that as a third option. |
The issue here is that by having two separate repositories one with the base infrastructure and the code, these two things will eventually diverge and break depending on the specific dependencies as the code base changes and grows. I don't really care if it is my solution, or someone elses, but it should be easily validated and the Dockerfile should be in lock-step with the code due to dependencies at that current point in time. Having two different repositories is a not very good idea as these WILL get out of sync. Could you please reconsider? I have tested this, and it works on MacOS, likely Linux, and probably WSL2. I haven't tested the last two, but we can get someone else to do that and I can help maintain this portion. |
This should allow anyone who is capable of running docker on Linux, macOS, or Windows with WSL2 to effectively compile on Ubuntu 24.04 without tainting their own personal machine with build tools. Scripts to facilitate building of the containers and running them will be added in a separate PR. Added one small fix to the .gitignore file for macOS users as a drive by. Edited the top level README.md to point to the docker instructions for those who wish to use this. It has been tested on macOS.
03c3d5c to
cb769f7
Compare
This should allow anyone who is capable of running docker on Linux, macOS, or Windows with WSL2 to effectively compile on Ubuntu 24.04 without tainting their own personal machine with build tools.
Scripts to facilitate building of the containers and running them will be added in a separate PR.
Added one small fix to the .gitignore file for macOS users as a drive by.
Edited the top level README.md to point to the docker instructions for those who wish to use this.
It has been tested on macOS.